posix: system_database_r: remove invalid compilation filters #95224
Conversation
|
@JarmouniA - I forgot to fill in a part of the commit message, but it is the right one. Let me update Edit: oh, actually - the |
pwd.c and grp.c both had incorrect preprocessor guards around the stubs that they were implementing. Functions were surrounded by ```cpp ifdef CONFIG_POSIX_THREAD_SAFE_FUNCTIONS .. endif /* CONFIG_POSIX_THREAD_SAFE_FUNCTIONS */ ``` Which is not at all accurate, since that subprofiling option group is `(CONFIG_)POSIX_SYSTEM_DATABASE_R` (which is a PR that is in-draft). Remove the guards, since they are invalid anyway, and at most an application will link properly. We don't really need the guards anyway, since conditional compilation will be used to link the files into the build. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
posix-system-database-r-remove-invalid-preprocessor-guards
branch
from
e86abfe to
563f892
Compare
|
Are you referring to this? zephyr/lib/posix/options/CMakeLists.txt Line 142 in 1e85543 |
Not exactly. This from #84858 if (NOT CONFIG_TC_PROVIDES_POSIX_SYSTEM_DATABASE_R)
zephyr_library_sources_ifdef(CONFIG_POSIX_SYSTEM_DATABASE_R
system_database_priv.c
system_database_r.c
)
endif() |
The files
pwd.candgrp.cboth had incorrect preprocessor guards around the stubs that they were implementing. Functions were surrounded bywhich is not at all accurate, since that subprofiling option group is
(CONFIG_)POSIX_SYSTEM_DATABASE_R.https://pubs.opengroup.org/onlinepubs/9699919799/xrat/V4_subprofiles.html
Remove the guards, since they are invalid anyway, and at least allow applications to link properly.
Required by #88547